Making output limit configurable

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Making output limit configurable

Sidu Ponnappa-2
Folks,

Shall I go ahead and merge Valentin's patch to make the output size
configurable? You can find his changes at  
http://github.com/valo/cruisecontrol.rb

Thanks,
Sidu.

-------- Original Message --------
Subject: Re: [GitHub] valo sent you a message
Date: Fri, 30 Oct 2009 01:37:50 +0530
From: C. K. Ponnappa <[hidden email]>
To: Valentin Mihov <[hidden email]>
References: <[hidden email]>
<[hidden email]>
<[hidden email]>



Sure Valentin, more tests are always welcome. In the meanwhile I will
get Alexey and others to review and once approved, I will merge changes.

Thanks ever so much!
Sidu.
http://blog.sidu.in
http://twitter.com/ponnappa

Valentin Mihov wrote:

> OK. This time the unit tests are not failing. I have forgotten to
> declare the assessors for the output_limit. I changed it in our CI,
> but forgot to push it to github. It should be better now.
>
> Should I write some unit tests for the new config var?
>
> Here is the fix:
> http://github.com/valo/cruisecontrol.rb/commit/e1037bff7278ba1471dd4b91b88ee8d86bb19f14
>
> Thanks,
>   Valentin
>
> On Thu, Oct 29, 2009 at 4:56 AM, C. K. Ponnappa <[hidden email]> wrote:
>  
>> Hey Valentin,
>>
>> Your patch looks good, but I have 7 failing tests after pulling; I just
>> wanted to confirm if this is happening for you (looks like a missing
>> cattr_reader :output_limit in Configuration)?
>> We can merge it in once the others have approved the change.
>>
>> Thanks,
>> Sidu.
>> http://blog.sidu.in
>> http://twitter.com/ponnappa
>>
>> GitHub wrote:
>>    
>>> valo wants you to pull from valo/cruisecontrol.rb at master
>>>
>>> Body: Hi there!
>>>
>>> I made a patch to make the output limit of 100KB configurable. It is a
>>> global config option on the Configuration class. If you want and like the
>>> patch you can pull it.
>>>
>>> Please tell me if the fix is not good enough.
>>>
>>> Thanks,
>>>  Valentin
>>>
>>> View repository: http://github.com/valo/cruisecontrol.rb/tree/master
>>>
>>>
>>>      
>
>  


_______________________________________________
Cruisecontrolrb-developers mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers
Reply | Threaded
Open this post in threaded view
|

Re: Making output limit configurable

Chad Woolley
On Thu, Oct 29, 2009 at 1:11 PM, C. K. Ponnappa <[hidden email]> wrote:
> Folks,
>
> Shall I go ahead and merge Valentin's patch to make the output size
> configurable? You can find his changes at
>  http://github.com/valo/cruisecontrol.rb

I'd feel better about it if the build were green and building reliably:

http://cruisecontrolrb.thoughtworks.com/builds/CruiseControlRB

-- Chad
_______________________________________________
Cruisecontrolrb-developers mailing list
[hidden email]
http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers