Give me some love on old PRs

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Give me some love on old PRs

Alberto Almagro
Hello Rails!

I know this kind of message isn't what we are used to see in this mailing list, most of the times we discuss about feature requests and cool suggestions, but this is also a foreseen topic for this mailing list as the Contributing to Ruby on Rails guide states:

If it's been over a week, and you haven't heard anything, you might want to try and nudge things along. You can use the rubyonrails-core mailing list for this. You can also leave another comment on the pull request.


So let's try it! I have four PRs that need feedback from the core team. I would like to have them ready in order to continue with other developments that depend on them. All of them have already been there for a long time, in the best cases more than 7 days since my last comment requesting feedback. Please give them somebody to love ;)
  • https://github.com/rails/rails/pull/34352
  • https://github.com/rails/rails/pull/33465
  • https://github.com/rails/rails/pull/33967
  • https://github.com/rails/rails/pull/34085

As always, thanks in advance for your time and reviews!!

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Give me some love on old PRs

mark-3
May I tag along and also mention this PR related to ActiveModel::Errors?


Thanks

Alberto Almagro於 2018年11月15日星期四 UTC+8上午6時15分48秒寫道:
Hello Rails!

I know this kind of message isn't what we are used to see in this mailing list, most of the times we discuss about feature requests and cool suggestions, but this is also a foreseen topic for this mailing list as the <a href="https://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#get-some-feedback" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fguides.rubyonrails.org%2Fcontributing_to_ruby_on_rails.html%23get-some-feedback\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFq8kOPxOnCsN6wa2bEQox7zc-rZQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fguides.rubyonrails.org%2Fcontributing_to_ruby_on_rails.html%23get-some-feedback\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFq8kOPxOnCsN6wa2bEQox7zc-rZQ&#39;;return true;">Contributing to Ruby on Rails guide states:

If it's been over a week, and you haven't heard anything, you might want to try and nudge things along. You can use the <a href="https://groups.google.com/forum/#!forum/rubyonrails-core" style="outline:0px;font-size:14px;background-image:initial;background-position:initial;background-repeat:initial;color:rgb(152,9,5);font-family:Helvetica,Arial,sans-serif" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/forum/#!forum/rubyonrails-core&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/forum/#!forum/rubyonrails-core&#39;;return true;">rubyonrails-core mailing list for this. You can also leave another comment on the pull request.


So let's try it! I have four PRs that need feedback from the core team. I would like to have them ready in order to continue with other developments that depend on them. All of them have already been there for a long time, in the best cases more than 7 days since my last comment requesting feedback. Please give them somebody to love ;)
  • <a href="https://github.com/rails/rails/pull/34352" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F34352\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHTPjHJ7Nfk4l88uk6RxaOhQqI8kg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F34352\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHTPjHJ7Nfk4l88uk6RxaOhQqI8kg&#39;;return true;">https://github.com/rails/rails/pull/34352
  • <a href="https://github.com/rails/rails/pull/33465" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F33465\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEsvQdWEMfjIVzW2cAk-UyaOQwMTQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F33465\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNEsvQdWEMfjIVzW2cAk-UyaOQwMTQ&#39;;return true;">https://github.com/rails/rails/pull/33465
  • <a href="https://github.com/rails/rails/pull/33967" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F33967\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF1H7saXyD1O9fBHw6mvj81c9AjFg&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F33967\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNF1H7saXyD1O9fBHw6mvj81c9AjFg&#39;;return true;">https://github.com/rails/rails/pull/33967
  • <a href="https://github.com/rails/rails/pull/34085" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F34085\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFZzPlkxPtqyqYxOVqyLkoUWDBcJw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F34085\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFZzPlkxPtqyqYxOVqyLkoUWDBcJw&#39;;return true;">https://github.com/rails/rails/pull/34085

As always, thanks in advance for your time and reviews!!

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.