Feedback on PR?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Feedback on PR?

Nick Holden
Hello!

I opened this pull request a few weeks ago, and I'd love to get some feedback. The Contributing to Ruby on Rails guide suggested that this mailing list might be a good place to help nudge things along. Let me know if there's any other context I can provide that would be useful.

Thanks!

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Feedback on PR?

Alberto Almagro
I guess this message had it effect as this was already reviewed and merged.

Great PR and great contribution! Thanks Nick!

El lunes, 26 de marzo de 2018, 18:14:12 (UTC+2), Nick Holden escribió:
Hello!

I opened <a href="https://github.com/rails/rails/pull/32185" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F32185\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFVa6JSIewtO8MeYQ00AblbKUJFHw&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F32185\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFVa6JSIewtO8MeYQ00AblbKUJFHw&#39;;return true;">this pull request a few weeks ago, and I'd love to get some feedback. The <a href="http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#get-some-feedback" target="_blank" rel="nofollow" onmousedown="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fedgeguides.rubyonrails.org%2Fcontributing_to_ruby_on_rails.html%23get-some-feedback\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHvvilie4v8zVqvoizeuA9xodYniQ&#39;;return true;" onclick="this.href=&#39;http://www.google.com/url?q\x3dhttp%3A%2F%2Fedgeguides.rubyonrails.org%2Fcontributing_to_ruby_on_rails.html%23get-some-feedback\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNHvvilie4v8zVqvoizeuA9xodYniQ&#39;;return true;">Contributing to Ruby on Rails guide suggested that this mailing list might be a good place to help nudge things along. Let me know if there's any other context I can provide that would be useful.

Thanks!

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.