[Feature] Support parsing msgpack parameters natively

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Feature] Support parsing msgpack parameters natively

Hirad Y.

I'd like to request to support parsing MsgPack parameters along with other already available parsers (i.e. json and xml parsers).


Thanks

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Feature] Support parsing msgpack parameters natively

Kasper Hansen
Hey,

I don’t see the reason for why we would accept a PR to add that parsing within Rails. Make a gem ✌️

--
Kasper
On 23 Sep 2019, 10.52 +0200, Hirad Y. <[hidden email]>, wrote:

I'd like to request to support parsing MsgPack parameters along with other already available parsers (i.e. json and xml parsers).


Thanks

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/3d33f9ff-6caf-49fa-9d3b-ea5dbed0625f%40Spark.
Reply | Threaded
Open this post in threaded view
|

Re: [Feature] Support parsing msgpack parameters natively

Hirad Y.
Hi Kasper, thanks for your reply. Why not?! parsing json/xml parameters are built, but not msgpack? I understand it is more of a binary format, but can be simply wrapped in with params hash in specific order, which correspond to activerecord attributes. I'm failing to see the reason for your ambiguous straightforward `no` answer!

On Saturday, 28 September 2019 20:08:33 UTC+1, Kasper Timm Hansen wrote:
Hey,

I don’t see the reason for why we would accept a PR to add that parsing within Rails. Make a gem ✌️

--
Kasper
On 23 Sep 2019, 10.52 +0200, Hirad Y. <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="kx5Vz6DoBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">hir...@...>, wrote:

I'd like to request to support parsing MsgPack parameters along with other already available parsers (i.e. json and xml parsers).


Thanks

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="kx5Vz6DoBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">rubyonra...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Feature] Support parsing msgpack parameters natively

Kasper Hansen
This isn’t really fruitful. You’re volunteering this discussion, so it’s on you to provide reasons. Which could be benefits of msgpack compared to xml/json, how does browsers support it, performance benchmarks, a gist with an attempt at a patch, etc.

Instead your request boils down to “I want msgpack, so you should write it and maintain it because I said so”. To which the only answer is: nope.

Making a gem is the only way I see this moving forward, then there’d be something to talk about ✌️

--
Kasper
On 28 Sep 2019, 21.53 +0200, Hirad Y. <[hidden email]>, wrote:
Hi Kasper, thanks for your reply. Why not?! parsing json/xml parameters are built, but not msgpack? I understand it is more of a binary format, but can be simply wrapped in with params hash in specific order, which correspond to activerecord attributes. I'm failing to see the reason for your ambiguous straightforward `no` answer!

On Saturday, 28 September 2019 20:08:33 UTC+1, Kasper Timm Hansen wrote:
Hey,

I don’t see the reason for why we would accept a PR to add that parsing within Rails. Make a gem ✌️

--
Kasper
On 23 Sep 2019, 10.52 +0200, Hirad Y. <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="kx5Vz6DoBgAJ" rel="nofollow">hir...@...>, wrote:

I'd like to request to support parsing MsgPack parameters along with other already available parsers (i.e. json and xml parsers).


Thanks

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="kx5Vz6DoBgAJ" rel="nofollow">rubyonra...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/2f708316-5257-418d-8c41-419a6390071d%40Spark.
Reply | Threaded
Open this post in threaded view
|

Re: [Feature] Support parsing msgpack parameters natively

Hirad Y.
I think it's best to stop this conversation right here, as I understand there's a huge lack of interest/knowledge on employing http/2 in future versions of Rails, and also Rails is not only used in web and can be used as a web api to any other application. 

I was at least hoping for a better discussion with an open mind contributor here than one who's ignoring any other possibilities to even get into a discussion than claiming to be "I am a Rails contributor, therefore all I say is the final fact!"

On Saturday, 28 September 2019 22:06:39 UTC+1, Kasper Timm Hansen wrote:
This isn’t really fruitful. You’re volunteering this discussion, so it’s on you to provide reasons. Which could be benefits of msgpack compared to xml/json, how does browsers support it, performance benchmarks, a gist with an attempt at a patch, etc.

Instead your request boils down to “I want msgpack, so you should write it and maintain it because I said so”. To which the only answer is: nope.

Making a gem is the only way I see this moving forward, then there’d be something to talk about ✌️

--
Kasper
On 28 Sep 2019, 21.53 +0200, Hirad Y. <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="zd_TzhLvBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">hir...@...>, wrote:
Hi Kasper, thanks for your reply. Why not?! parsing json/xml parameters are built, but not msgpack? I understand it is more of a binary format, but can be simply wrapped in with params hash in specific order, which correspond to activerecord attributes. I'm failing to see the reason for your ambiguous straightforward `no` answer!

On Saturday, 28 September 2019 20:08:33 UTC+1, Kasper Timm Hansen wrote:
Hey,

I don’t see the reason for why we would accept a PR to add that parsing within Rails. Make a gem ✌️

--
Kasper
On 23 Sep 2019, 10.52 +0200, Hirad Y. <[hidden email]>, wrote:

I'd like to request to support parsing MsgPack parameters along with other already available parsers (i.e. json and xml parsers).


Thanks

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to <a href="javascript:" target="_blank" gdf-obfuscated-mailto="zd_TzhLvBgAJ" rel="nofollow" onmousedown="this.href=&#39;javascript:&#39;;return true;" onclick="this.href=&#39;javascript:&#39;;return true;">rubyonra...@googlegroups.com.
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com?utm_medium=email&amp;utm_source=footer" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/14372071-22ca-473e-9e10-5dcd9095c06a%40googlegroups.com.
Reply | Threaded
Open this post in threaded view
|

Re: [Feature] Support parsing msgpack parameters natively

Hirad Y.
FYI, the gem already exist if bother looking around!

On Sunday, 29 September 2019 09:25:52 UTC+1, Hirad Y. wrote:
I think it's best to stop this conversation right here, as I understand there's a huge lack of interest/knowledge on employing http/2 in future versions of Rails, and also Rails is not only used in web and can be used as a web api to any other application. 

I was at least hoping for a better discussion with an open mind contributor here than one who's ignoring any other possibilities to even get into a discussion than claiming to be "I am a Rails contributor, therefore all I say is the final fact!"

On Saturday, 28 September 2019 22:06:39 UTC+1, Kasper Timm Hansen wrote:
This isn’t really fruitful. You’re volunteering this discussion, so it’s on you to provide reasons. Which could be benefits of msgpack compared to xml/json, how does browsers support it, performance benchmarks, a gist with an attempt at a patch, etc.

Instead your request boils down to “I want msgpack, so you should write it and maintain it because I said so”. To which the only answer is: nope.

Making a gem is the only way I see this moving forward, then there’d be something to talk about ✌️

--
Kasper
On 28 Sep 2019, 21.53 +0200, Hirad Y. <[hidden email]>, wrote:
Hi Kasper, thanks for your reply. Why not?! parsing json/xml parameters are built, but not msgpack? I understand it is more of a binary format, but can be simply wrapped in with params hash in specific order, which correspond to activerecord attributes. I'm failing to see the reason for your ambiguous straightforward `no` answer!

On Saturday, 28 September 2019 20:08:33 UTC+1, Kasper Timm Hansen wrote:
Hey,

I don’t see the reason for why we would accept a PR to add that parsing within Rails. Make a gem ✌️

--
Kasper
On 23 Sep 2019, 10.52 +0200, Hirad Y. <[hidden email]>, wrote:

I'd like to request to support parsing MsgPack parameters along with other already available parsers (i.e. json and xml parsers).


Thanks

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/rubyonrails-core/c7f4d5ef-4a62-46f6-bd43-e571d52ac359%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com?utm_medium=email&amp;utm_source=footer" rel="nofollow" target="_blank" onmousedown="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;" onclick="this.href=&#39;https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com?utm_medium\x3demail\x26utm_source\x3dfooter&#39;;return true;">https://groups.google.com/d/msgid/rubyonrails-core/7bff5f66-6276-4e96-b05d-6560598c95d7%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-core/71df65aa-c127-4c1d-b948-aee290ae548b%40googlegroups.com.