Add error logging to ActiveJob (merge PR 28582)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Add error logging to ActiveJob (merge PR 28582)

Steven Bull
I've submitted a PR to add error logging to Active Job - https://github.com/rails/rails/pull/28582.

Since it's been a couple of weeks with no comments made to the PR, I'm pointing it out here (as directed in the Contributing guide).

The original issue description is https://github.com/rails/rails/issues/26848. In brief, the PR changes only the default logging activity of jobs that raise exceptions from logging "Performed ..." (at info level), identical to the log message for non-exceptional jobs, to "Error performing ... <exception class + message + backtrace" (at error level).

It would be nice to get this into 5.1.

Thanks,
Steve

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.
Reply | Threaded
Open this post in threaded view
|

Re: Add error logging to ActiveJob (merge PR 28582)

Steven Bull
This PR has been merged (thanks @rafaelfranca).

On Monday, April 10, 2017 at 4:07:26 PM UTC-7, Steven Bull wrote:
I've submitted a PR to add error logging to Active Job - <a href="https://github.com/rails/rails/pull/28582" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F28582\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNG_6X8oLxosxX80CNP4GLEvh4AMJQ&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fpull%2F28582\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNG_6X8oLxosxX80CNP4GLEvh4AMJQ&#39;;return true;">https://github.com/rails/rails/pull/28582.

Since it's been a couple of weeks with no comments made to the PR, I'm pointing it out here (as directed in the Contributing guide).

The original issue description is <a href="https://github.com/rails/rails/issues/26848" target="_blank" rel="nofollow" onmousedown="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fissues%2F26848\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFvBcZ3nKqRaMsEyFOQ9Ys4tV9VLA&#39;;return true;" onclick="this.href=&#39;https://www.google.com/url?q\x3dhttps%3A%2F%2Fgithub.com%2Frails%2Frails%2Fissues%2F26848\x26sa\x3dD\x26sntz\x3d1\x26usg\x3dAFQjCNFvBcZ3nKqRaMsEyFOQ9Ys4tV9VLA&#39;;return true;">https://github.com/rails/rails/issues/26848. In brief, the PR changes only the default logging activity of jobs that raise exceptions from logging "Performed ..." (at info level), identical to the log message for non-exceptional jobs, to "Error performing ... <exception class + message + backtrace" (at error level).

It would be nice to get this into 5.1.

Thanks,
Steve

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [hidden email].
To post to this group, send email to [hidden email].
Visit this group at https://groups.google.com/group/rubyonrails-core.
For more options, visit https://groups.google.com/d/optout.